ext/gmp: Emit deprecation for precision-losing float RHS in ** / << / >>#21935
ext/gmp: Emit deprecation for precision-losing float RHS in ** / << / >>#21935LamentXU123 wants to merge 6 commits intophp:PHP-8.4from
Conversation
|
I think a decision (aka RFC) needs to be made about it first, not entirely sure though. |
There are comments about this in the original code base so maybe this is some sort of TODO task, I think the correct behavior is decided when the comment is written. Anyway, the code is written in PHP 8.2.6 and I guess the original idea is to correct the behavior after 8.3 when we have the corresponding try method, and people might just forget it :) |
|
oh I do not deny the correctness of it, just talking about this as a whole procedure but let s wait the maintainer's opinion ;) |
|
I don’t rule out the possibility that the comment was overlooked, but since this is not a bug fix, the target branch needs to be |
|
@SakiTakamachi #21945 is now targeting master branch. I am closing this now |
3 participants
I found this TODO message in the code base
Ah, so using zend_try_long() here will cause some precision loss and should be fixed after 8.3. So I created this PR targeting 8.4. I don't sure if this worth a NEWS entry. Also may need to merge this PR to other branches since I don't have access :)
cc @Girgias